Skip to content

fix(RHOAIENG-20531): propagate annotations to ray pods#809

Merged
laurafitzgerald merged 1 commit into
project-codeflare:mainfrom
chipspeak:RHOAIENG-20531
May 13, 2025
Merged

fix(RHOAIENG-20531): propagate annotations to ray pods#809
laurafitzgerald merged 1 commit into
project-codeflare:mainfrom
chipspeak:RHOAIENG-20531

Conversation

@chipspeak

@chipspeak chipspeak commented Mar 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue link

RHOAIENG-20531

What changes have been made

Fix to propagate annotations passed in the cluster config to the Ray head and worker pods.

Verification steps

  • Pass an annotation during cluster definition in a notebook.
  • Check the CR on cluster and the annotation should be reflected there.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2025
@codecov

codecov Bot commented Mar 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.45%. Comparing base (e46ee4c) to head (11eb02d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #809   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files          24       24           
  Lines        1419     1419           
=======================================
  Hits         1312     1312           
  Misses        107      107

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chipspeak chipspeak marked this pull request as ready for review March 18, 2025 12:12
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2025
Bobbins228
Bobbins228 suggested changes Mar 19, 2025
View reviewed changes

@Bobbins228 Bobbins228 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks clean but the annotations config vars are added to tests that are not really necessary/are helper functions.

The create_cluster_all_config_params() test is a fine place to put them for testing purposes but you need to assert that the params are set properly in the test_config_creation_all_parameters Unit Test.

Comment thread src/codeflare_sdk/ray/cluster/test_config.py Outdated
Comment thread src/codeflare_sdk/ray/cluster/test_config.py Outdated
Comment thread tests/e2e/mnist_raycluster_sdk_kind_test.py Outdated
Comment thread src/codeflare_sdk/common/utils/unit_test_support.py Outdated
Comment thread src/codeflare_sdk/common/utils/unit_test_support.py Outdated
Comment thread demo-notebooks/guided-demos/0_basic_ray.ipynb Outdated
@chipspeak chipspeak force-pushed the RHOAIENG-20531 branch 2 times, most recently from 901de36 to 6529505 Compare March 24, 2025 09:21
Bobbins228
Bobbins228 previously requested changes Mar 24, 2025
View reviewed changes
Comment thread src/codeflare_sdk/common/utils/unit_test_support.py Outdated
@chipspeak chipspeak requested a review from Bobbins228 April 23, 2025 13:50
@chipspeak chipspeak requested a review from kryanbeane May 12, 2025 07:12
@Bobbins228 Bobbins228 dismissed their stale review May 12, 2025 08:05

Outdated

@laurafitzgerald

laurafitzgerald commented May 12, 2025

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 12, 2025
@laurafitzgerald

laurafitzgerald commented May 12, 2025

Copy link
Copy Markdown
Contributor

/override kubernetes

@openshift-ci

openshift-ci Bot commented May 12, 2025

Copy link
Copy Markdown
Contributor

@laurafitzgerald: Overrode contexts on behalf of laurafitzgerald: kubernetes

Details

In response to this:

/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@project-codeflare project-codeflare deleted a comment from openshift-ci Bot May 12, 2025
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
@chipspeak
fix(RHOAIENG-20531): propagate annotations to ray pods
11eb02d 
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
kryanbeane
kryanbeane approved these changes May 13, 2025
View reviewed changes

@kryanbeane kryanbeane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/override kubernetes

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
@openshift-ci

openshift-ci Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

@kryanbeane: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • kubernetes

Only the following failed contexts/checkruns were expected:

  • add-approve-lgtm-label
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/lgtm
/approve
/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kryanbeane
kryanbeane approved these changes May 13, 2025
View reviewed changes

@kryanbeane kryanbeane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/override kubernetes

@openshift-ci

openshift-ci Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

@kryanbeane: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • kubernetes

Only the following failed contexts/checkruns were expected:

  • add-approve-lgtm-label
  • tide
  • verify-0_basic_ray
  • verify-1_cluster_job_client
  • verify-2_basic_interactive
  • verify-3_widget_example
  • verify-local_interactive
  • verify-ray_job_client

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/lgtm
/approve
/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane, laurafitzgerald

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kryanbeane,laurafitzgerald]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kryanbeane

kryanbeane commented May 13, 2025

Copy link
Copy Markdown
Contributor

/override kubernetes

@openshift-ci

openshift-ci Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

@kryanbeane: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • kubernetes

Only the following failed contexts/checkruns were expected:

  • add-approve-lgtm-label
  • tide
  • verify-0_basic_ray
  • verify-1_cluster_job_client
  • verify-2_basic_interactive
  • verify-3_widget_example
  • verify-local_interactive
  • verify-ray_job_client

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kryanbeane

kryanbeane commented May 13, 2025

Copy link
Copy Markdown
Contributor

/override tide

@openshift-ci

openshift-ci Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

@kryanbeane: Overrode contexts on behalf of kryanbeane: tide

Details

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@laurafitzgerald

laurafitzgerald commented May 13, 2025

Copy link
Copy Markdown
Contributor

/override kubernetes

@openshift-ci

openshift-ci Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

@laurafitzgerald: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • kubernetes

Only the following failed contexts/checkruns were expected:

  • add-approve-lgtm-label
  • tide
  • verify-0_basic_ray
  • verify-1_cluster_job_client
  • verify-2_basic_interactive
  • verify-3_widget_example
  • verify-local_interactive
  • verify-ray_job_client

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@laurafitzgerald laurafitzgerald merged commit 340f973 into project-codeflare:main May 13, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kryanbeane kryanbeane kryanbeane approved these changes

@Fiona-Waters Fiona-Waters Awaiting requested review from Fiona-Waters

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@Bobbins228 Bobbins228 Awaiting requested review from Bobbins228

Assignees

@laurafitzgerald laurafitzgerald

@kryanbeane kryanbeane

@Bobbins228 Bobbins228

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chipspeak @laurafitzgerald @kryanbeane @Bobbins228